Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6bbde4c8e679
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 16516df953b3
Choose a head ref
  • 4 commits
  • 7 files changed
  • 1 contributor

Commits on Mar 23, 2019

  1. pythonPackages.jaraco_itertools: fix build

    The package currently fails because of some flake8 violations. However
    invalid coding style shouldn't break the Nix package.
    
    See also https://hydra.nixos.org/build/90115508
    Addresses #56826
    
    (cherry picked from commit eede376)
    Ma27 authored and Robert Schütz committed Mar 23, 2019
    Copy the full SHA
    105d99a View commit details
  2. pythonPackages.jaraco_text: 2.0 -> 3.0

    This fixes the dependency cycle between `jaraco_text` and
    `jaraco_collections`. Reported upstream in jaraco/jaraco.text#3
    
    See also https://hydra.nixos.org/build/90307068
    See also https://hydra.nixos.org/build/90310398
    Addresses #56826
    
    (cherry picked from commit 4c57b5e)
    Ma27 authored and Robert Schütz committed Mar 23, 2019

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c222255 View commit details
  3. pythonPackages.jaraco_logging: fix build

    The package currently fails because of some flake8 violations. However
    invalid coding style shouldn't break the Nix package.
    
    See also https://hydra.nixos.org/build/90301692
    Addresses #56826
    
    (cherry picked from commit 18b0729)
    Ma27 authored and Robert Schütz committed Mar 23, 2019
    Copy the full SHA
    ef9238f View commit details
  4. python3Packages.irc: fix build

    Adds missing `jaraco_collections` dependency. This also unbreaks
    `errbot`.
    
    See also https://hydra.nixos.org/build/90116401
    Addresses #56826
    
    (cherry picked from commit 8159a1f)
    Ma27 authored and Robert Schütz committed Mar 23, 2019
    Copy the full SHA
    16516df View commit details
4 changes: 3 additions & 1 deletion pkgs/development/python-modules/irc/default.nix
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{ buildPythonPackage, fetchPypi, isPy3k
, six, jaraco_logging, jaraco_text, jaraco_stream, pytz, jaraco_itertools
, setuptools_scm }:
, setuptools_scm, jaraco_collections
}:

buildPythonPackage rec {
pname = "irc";
@@ -23,5 +24,6 @@ buildPythonPackage rec {
jaraco_stream
pytz
jaraco_itertools
jaraco_collections
];
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ buildPythonPackage, fetchPypi, setuptools_scm
, six, jaraco_classes }:
, six, jaraco_classes, jaraco_text
}:

buildPythonPackage rec {
pname = "jaraco.collections";
@@ -11,7 +12,7 @@ buildPythonPackage rec {

doCheck = false;
buildInputs = [ setuptools_scm ];
propagatedBuildInputs = [ six jaraco_classes ];
propagatedBuildInputs = [ six jaraco_classes jaraco_text ];

# break dependency cycle
patchPhase = ''
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
From fcffcc61e432e5250e7fbfb1ecbe0f1cac3006cf Mon Sep 17 00:00:00 2001
From: Maximilian Bosch <maximilian@mbosch.me>
Date: Sun, 10 Mar 2019 13:10:18 +0100
Subject: [PATCH] Don't run flake8 checks during the build

If the code simply violates their code style, the Nix package shouldn't fail.
---
pytest.ini | 2 +-
setup.cfg | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/pytest.ini b/pytest.ini
index d165e5e..d8e4694 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -1,6 +1,6 @@
[pytest]
norecursedirs=dist build .tox .eggs
-addopts=--doctest-modules --flake8
+addopts=--doctest-modules
doctest_optionflags=ALLOW_UNICODE ELLIPSIS ALLOW_BYTES
filterwarnings=
ignore:Possible nested set::pycodestyle:113
diff --git a/setup.cfg b/setup.cfg
index 9f3517f..c9033ec 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -30,7 +30,6 @@ setup_requires = setuptools_scm >= 1.15.0
testing =
pytest >= 3.5, !=3.7.3
pytest-checkdocs
- pytest-flake8
docs =
sphinx
jaraco.packaging >= 3.2
--
2.18.1

7 changes: 5 additions & 2 deletions pkgs/development/python-modules/jaraco_itertools/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ lib, buildPythonPackage, fetchPypi, setuptools_scm
, inflect, more-itertools, six, pytest, pytest-flake8 }:
, inflect, more-itertools, six, pytest
}:

buildPythonPackage rec {
pname = "jaraco.itertools";
@@ -10,9 +11,11 @@ buildPythonPackage rec {
sha256 = "d1380ed961c9a4724f0bcca85d2bffebaa2507adfde535d5ee717441c9105fae";
};

patches = [ ./0001-Don-t-run-flake8-checks-during-the-build.patch ];

buildInputs = [ setuptools_scm ];
propagatedBuildInputs = [ inflect more-itertools six ];
checkInputs = [ pytest pytest-flake8 ];
checkInputs = [ pytest ];

checkPhase = ''
pytest
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
From 4b9801d9bbe535fd6719933b96278915573e3595 Mon Sep 17 00:00:00 2001
From: Maximilian Bosch <maximilian@mbosch.me>
Date: Sun, 10 Mar 2019 16:42:21 +0100
Subject: [PATCH] Don't run flake8 checks during the build

If the code simply violates their code style, the Nix package shouldn't fail.
---
pytest.ini | 2 +-
setup.cfg | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/pytest.ini b/pytest.ini
index 9b3c1ec..a5189c1 100644
--- a/pytest.ini
+++ b/pytest.ini
@@ -1,6 +1,6 @@
[pytest]
norecursedirs=dist build .tox .eggs
-addopts=--doctest-modules --flake8
+addopts=--doctest-modules
doctest_optionflags=ALLOW_UNICODE ELLIPSIS
filterwarnings=
ignore:Possible nested set::pycodestyle:113
diff --git a/setup.cfg b/setup.cfg
index 3e7bbed..5cac7a2 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -29,7 +29,6 @@ setup_requires = setuptools_scm >= 1.15.0
testing =
pytest >= 3.5, !=3.7.3
pytest-checkdocs
- pytest-flake8
docs =
sphinx
jaraco.packaging >= 3.2
--
2.18.1

7 changes: 5 additions & 2 deletions pkgs/development/python-modules/jaraco_logging/default.nix
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{ lib, buildPythonPackage, fetchPypi, setuptools_scm
, tempora, six, pytest, pytest-flake8 }:
, tempora, six, pytest
}:

buildPythonPackage rec {
pname = "jaraco.logging";
@@ -10,9 +11,11 @@ buildPythonPackage rec {
sha256 = "1lb846j7qs1hgqwkyifv51nhl3f8jimbc4lk8yn9nkaynw0vyzcg";
};

patches = [ ./0001-Don-t-run-flake8-checks-during-the-build.patch ];

buildInputs = [ setuptools_scm ];
propagatedBuildInputs = [ tempora six ];
checkInputs = [ pytest pytest-flake8 ];
checkInputs = [ pytest ];

checkPhase = ''
PYTHONPATH=".:$PYTHONPATH" pytest
9 changes: 5 additions & 4 deletions pkgs/development/python-modules/jaraco_text/default.nix
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
{ buildPythonPackage, fetchPypi, setuptools_scm
, jaraco_functools, jaraco_collections }:
, jaraco_functools
}:

buildPythonPackage rec {
pname = "jaraco.text";
version = "2.0";
version = "3.0";
src = fetchPypi {
inherit pname version;
sha256 = "3660678d395073626e72a455b24bacf07c064138a4cc6c1dae63e616f22478aa";
sha256 = "1l5hq2jvz9xj05aayc42f85v8wx8rpi16lxph8blw51wgnvymsyx";
};
doCheck = false;
buildInputs =[ setuptools_scm ];
propagatedBuildInputs = [ jaraco_functools jaraco_collections ];
propagatedBuildInputs = [ jaraco_functools ];
}