Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport] spectral: 2018-09-24 -> 2019-03-03 #58119

Merged
merged 2 commits into from Apr 20, 2019
Merged

[backport] spectral: 2018-09-24 -> 2019-03-03 #58119

merged 2 commits into from Apr 20, 2019

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Mar 22, 2019

Motivation for this change

I think after the qt 5.12 update the program stopped working due to the qml path problem.
This update fixes the issue so it should be backported.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change (none)
  • Tested execution of all binary files
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill @rnhmjoj
spectral: 2018-09-24 -> 2019-03-03
09255d4 
Recent redesign, features, fixes.

(cherry picked from commit ad3d9c0)
@rnhmjoj rnhmjoj changed the title spectral: 2018-09-24 -> 2019-03-03 [backport] spectral: 2018-09-24 -> 2019-03-03 Mar 22, 2019
timokau
timokau approved these changes Apr 11, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can only improve things since the package currently doesn't work at all. Thank you!

timokau
timokau requested changes Apr 11, 2019
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed the darwin failure. This is apparently already the case on master, so it should be sufficient to restrict the platforms to linux.

@rnhmjoj
spectral: disable darwin support
bb2b48c 
The build started to fail since the update to 2019-03-03.
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Apr 13, 2019

@timokau Done.

@timokau
Copy link
Member

timokau commented Apr 20, 2019

Sorry for the delay, missed the notification email.

@timokau timokau merged commit 73c8852 into NixOS:release-19.03 Apr 20, 2019
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Apr 20, 2019

No problem, thank you.

@rnhmjoj rnhmjoj deleted the spectral branch September 14, 2019 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timokau timokau timokau approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rnhmjoj @timokau @infinisil @GrahamcOfBorg @dtzWill