Skip to content

bazel: 0.22.0 -> 0.23.2 #58116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

bazel: 0.22.0 -> 0.23.2 #58116

wants to merge 1 commit into from
+4 −4

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Mar 22, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@uri-canva uri-canva requested a review from Profpatsch as a code owner March 22, 2019 08:54
@uri-canva
Copy link
Contributor Author

Not sure if this is going to be any different from #56587, worth a shot.

@marsam marsam mentioned this pull request Mar 22, 2019
Merged
10 tasks
@xeji
Copy link
Contributor

xeji commented Mar 24, 2019

@GrahamcOfBorg build bazel bazel-deps bazel-watcher

@uri-canva
Copy link
Contributor Author

Looks like the same issue as the other PR.

@uri-canva
Copy link
Contributor Author

Will close the PR to not give the impression I'm working on this at the moment, might try at some point. cc @groodt

@uri-canva uri-canva closed this Mar 24, 2019
@groodt
Copy link
Contributor

groodt commented Mar 25, 2019

Thanks @uri-canva

For anybody interested. I've tested using this derivation on my own fairly large build on linux and Darwin and it currently works as expected.

Got a link to the latest error for me to confirm if I can reproduce? On my Darwin machine, it currently builds, but I've never tried sandbox. I'll have to give it a try.

@uri-canva
Copy link
Contributor Author

See the checks tab.

@groodt groodt mentioned this pull request Mar 29, 2019
Closed
10 tasks
@uri-canva uri-canva reopened this Mar 31, 2019
@uri-canva
Copy link
Contributor Author

This probably would have been fine on hydra, see #58147 on why it was failing on ofborg.

@Profpatsch
Copy link
Member

We merged 0.24.

@Profpatsch Profpatsch closed this Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsam marsam

@Profpatsch Profpatsch

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@uri-canva @xeji @groodt @Profpatsch @marsam @GrahamcOfBorg