Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

miniflux: do not send buildGoPackage, it is using buildGoModule now #58110

Merged
merged 1 commit into from Mar 22, 2019
Merged

miniflux: do not send buildGoPackage, it is using buildGoModule now #58110

merged 1 commit into from Mar 22, 2019

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Mar 22, 2019 •
edited

Motivation for this change

Staging is currently not evaluating. Miniflux is no longer using buildGoPackage, so it must not be sent buildGoPackage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kalbasit kalbasit changed the title fix the eval of staging miniflux: do not send buildGoPackage, it is using buildGoModule now Mar 22, 2019
@kalbasit
Copy link
Member Author

@GrahamcOfBorg build miniflux

@kalbasit kalbasit merged commit 1f460d0 into NixOS:staging Mar 22, 2019
@kalbasit kalbasit deleted the nixpkgs_fix-staging-eval branch March 22, 2019 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@kalbasit