Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root5: fix build #58108

Merged
merged 2 commits into from
Mar 31, 2019
Merged

root5: fix build #58108

merged 2 commits into from
Mar 31, 2019
+262 −4

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Mar 22, 2019 •
edited
Loading

Motivation for this change

ROOT5 includes a C++ interpreter/introspection tool called cint (rootcint) which is also is being used during the build of ROOT itself. The interpreter will try to access libc headers at /usr/include, which is not pure and can possibly break the build. We also can not supply our glibc headers because those require a modern compiler. This fix should remove some of the direct access to libc/posix calls, that should not affect functionality very much.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-review
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

veprbl added 2 commits March 20, 2019 00:26
@veprbl
root5: fix build

Verified

This commit was signed with the committer’s verified signature. The key has expired.
veprbl Dmitry Kalinkin
GPG key ID: 06AF1D3C38F04E0E
Expired
Verified
Learn about vigilant mode
c36f841
@veprbl
applgrid: fix build for gcc

Verified

This commit was signed with the committer’s verified signature. The key has expired.
veprbl Dmitry Kalinkin
GPG key ID: 06AF1D3C38F04E0E
Expired
Verified
Learn about vigilant mode
cdab07b
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 22, 2019
@veprbl
Copy link
Member Author

veprbl commented Mar 22, 2019

@GrahamcOfBorg build xfitter

@dtzWill
Copy link
Member

dtzWill commented Mar 25, 2019 •
edited
Loading

BTW would it make sense to bump this to latest 5.x while visiting it?
78c6129 is what I mean.

(I imagine moving to the 6 series is a bigger deal--from packaging or usage perspectives?)

EDIT: nevermind the 5.x update, the patches will require some work so probably best to handle separately, waiting for a sufficiently motivated person :). No reason to make this block on tackling that, un-breaking 👍!

Since builders time out I'll at least confirm it builds on environments available to me...

@veprbl
Copy link
Member Author

veprbl commented Mar 25, 2019 •
edited
Loading

@dtzWill Thanks for the bump, I went with 5.34.36 for root5 because 5.34.38 was never announced and probably it is not as widely adopted.

We have 6.x branch under root. It is the one to be used by the most people. I am not aware of any such kind of impurities in 6.x that I fix in this PR. The root5 is needed for legacy purposes.

edit: backported to 19.03: 3ba0f35 a6ee6a5

@veprbl veprbl added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 25, 2019
@veprbl veprbl merged commit ea757ac into NixOS:master Mar 31, 2019
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
@veprbl veprbl deleted the pr/root5_fix branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @dtzWill @samueldr @GrahamcOfBorg