Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update now-cli to v14.2.3 #58184

Closed
wants to merge 1 commit into from
Closed

Update now-cli to v14.2.3 #58184

wants to merge 1 commit into from

Conversation

NathanielHill
Copy link
Contributor

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

aanderse
aanderse requested changes Apr 8, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NathanielHill please do take a moment to read CONTRIBUTING.md as it has useful tips.

Please rename this PR to "now-cli: 14.0.3 -> 14.2.3", and then rewrite your commit message to be the same.

@NathanielHill
Copy link
Contributor Author

@aanderse Thanks for the feedback. Zeit releases now CLI updates frequently, and I'm happy to maintain version bumps for this package.

Closing in favor of #59221 which follows the CONTRIBUTING.md you referenced.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse requested changes

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@NathanielHill @aanderse @infinisil @GrahamcOfBorg @Janik-Haag