Skip to content

anbox: fix build on x86_64-linux #58185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2019
Merged

anbox: fix build on x86_64-linux #58185

merged 1 commit into from
Mar 23, 2019
+1 −1

Conversation

benley
Copy link
Member

@benley benley commented Mar 23, 2019

Motivation for this change

x86-64-linux was a typo; there needs to be an underscore in there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@benley
anbox: fix build on x86_64-linux
fba697d 
`x86-64-linux` was a typo; there needs to be an underscore in there.
@benley benley requested review from gebner, worldofpeace and srhb March 23, 2019 20:00
@srhb srhb merged commit 06d7f2d into NixOS:master Mar 23, 2019
@srhb
Copy link
Contributor

srhb commented Mar 23, 2019

Thank you!

@benley
Copy link
Member Author

benley commented Mar 23, 2019

Fastest PR merge ever! 🥇

@benley benley deleted the benley/anbox-amd64 branch March 23, 2019 20:02
@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Mar 23, 2019
@GrahamcOfBorg GrahamcOfBorg requested a review from edwtjo March 23, 2019 20:13
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gebner gebner

@worldofpeace worldofpeace

@srhb srhb

@edwtjo edwtjo

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benley @srhb @GrahamcOfBorg