New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
androidenv: update packages #58131
androidenv: update packages #58131
Conversation
Actually this doesn't build when including system images; |
c98374c
to
861b16f
Compare
Updated with fixes for
|
861b16f
to
b30fbf0
Compare
Hi looks good so far, but I need a bit of time to review this. I need to check whether the testcases still pass and whether the frameworks built on top of it don't break. Moreover, I may still have to set the default |
Ah, understood. I've been trying to work out how to make Gradle builds possible in sandboxed mode, and it's not an easy problem to solve. |
How's this coming? (I re-ran update.sh on my local copy, and got a few duplicates, BTW). For things like the NDK, I think we should include a couple older versions here (maybe back to r17?) |
(BTW: if you want me to take over this PR, I'd be more than happy.) |
@numinit I'm happy to integrate this, as long as the default Once we have decent gradle build support then the 26.1.x version can be made the default. Making 26.1.x the default now will break the |
Any update here? |
Most changes in this PR are now in PR #82067 (scripts @tadfisher Could you please consider reviewing #82067 , and preparing a branch with any enhancements you envisage (e.g. I noticed you had amended the default versions - probably fruit of some testing) so we get most androidenv-related enhancements merged. |
I'm closing as all mentioned PRs above were merged. |
Motivation for this change
Update
generate.sh
to run usingnix-shell
. Also make it fail with meaningful output instead of writing empty output files.Generate the latest Android packages.
Update
composeAndroidPackages
with versions that exist in the generated package set.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)