doc/python: cleanup examples, references #58160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worldofpeace
commented
Mar 23, 2019
| @@ -585,11 +582,6 @@ The `buildPythonPackage` mainly does four things: | |||
| environment variable and add dependent libraries to script's `sys.path`. | |||
| * In the `installCheck` phase, `${python.interpreter} setup.py test` is ran. | |||
|
|
|||
| As in Perl, dependencies on other Python packages can be specified in the | |||
There was a problem hiding this comment.
This wasn't the best description, and the reference to perl didn't seem right here.
There's also
The `stdenv.mkDerivation` function accepts various parameters for describing build inputs (see "Specifying dependencies"). The following are of special
interest for Python packages
A bit below which is a good explanation with buildPython* in mind.
FRidh
added
the
9.needs: port to stable
FRidh
approved these changes
Mar 23, 2019
dotlambda
reviewed
Mar 23, 2019
The example didn't use pkgs.
|
In a followup to this (not completely related) would like to build off of 4bd168e because |
|
@FRidh @dotlambda Can either of you check off on this? |
|
lol, and I merged with fixup commits 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
1e86c0a let me actually see the examples we had, so I thought that we should improve them further.
This was done fairly quickly, so please tell me if there's something else I should touch.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)