Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

password-store: link ext. man pages into the password-store $out #58187

Merged
merged 1 commit into from Mar 24, 2019
Merged

password-store: link ext. man pages into the password-store $out #58187

merged 1 commit into from Mar 24, 2019

Conversation

kamidon
Copy link
Contributor

@kamidon kamidon commented Mar 23, 2019

Motivation for this change

When pass was installed with extensions in the system environment, the
man pages for the selected extensions were not available globally
because they were only available in a buildInput of the password-store
derivation.

Bug 56850

Things done

This commit resolves the problem by linking the man pages from the
extensions environment into the output directory of the password-store
derivation.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kamidon
password-store: link ext. man pages into the password-store $out
9830436 
When pass was installed with extensions in the system environment, the
man pages for the selected extensions were not available globally
because they were only available in a buildInput of the password-store
derivation.

This commit resolves the problem by linking the man pages from the
extensions environment into the output directory of the password-store
derivation.

Bug 56850
@kamidon kamidon mentioned this pull request Mar 23, 2019
Closed
@xeji xeji merged commit 69d0c14 into NixOS:master Mar 24, 2019
@kamidon kamidon deleted the pass-extensions-man-page-fix branch March 25, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovek323 lovek323 Awaiting requested review from lovek323

@fpletz fpletz Awaiting requested review from fpletz

@the-kenny the-kenny Awaiting requested review from the-kenny

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kamidon @GrahamcOfBorg @xeji