-
-
Notifications
You must be signed in to change notification settings - Fork 15.4k
buildRustCrate: overridable stdenv, and propagatedBuildInputs #58212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@GrahamcOfBorg eval |
@GrahamcOfBorg build buildRustCrateTests |
I started rebasing this onto master and also fixing a few nitpicks that I have. @P-E-Meunier do you have the exact list of packages that you added? Which of these (besides nettle) required the overrides? I am also working on adding a few tests for the override feature so we can verify that things work (now and in the future). |
Hi! I don't think there's anything really requiring work besides nettle, but I noticed a few problems when I started packaging the latest Pijul, due to the fact that Rust doesn't generate the same Cargo.lock for all featuresets (due to optional dependencies). I've published Carnix 0.10.1 onto crates.io last week, but haven't yet had the time to package it to nixpkgs yet. Also, I believe we need a giant common Cargo.lock in nixpkgs itself, which could be parsed more easily, and from which we could regenerate the nix expression. |
the HEAD of my modified branch is at a89441c. I'm leaving PR untouched for now. EDIT: just saw that you replied while I was typing. Parts of the below message are no longer relevant. We really need a mechanism to keep the crates.io package list smaller and thus should document / automate the process on how to generate the current list. If packages drop out of nixpkgs and those dependencies are no longer used we shouldn't carry it on forever. |
Regarding requiring a giant Cargo.lock: Not sure if you saw my idea in one of the previous carnix bumps that we could just iterate through all the packages that we know are using buildRustCrate (on a high-level, not all the crates-io.nix packages) and then re-generate the index with those. I hacked a very simple & error proune PoC https://gist.github.com/andir/c637c78450e6ae7815d98e7fa08d45dd We could probably eliminate the |
Heya ! |
Thank you for your contributions.
|
I marked this as stale due to inactivity. → More info |
Motivation for this change
These changes are both necessary to build crate nettle-sys.
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)