Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the main window using a separate class #2105

Merged
merged 15 commits into from
Mar 24, 2019

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Mar 23, 2019

No description provided.

adaptive_step_parameters.length_integration_tolerance);
prediction_steps_index_ = Array.FindIndex(
prediction_steps_,
(Int64 step) => step >= adaptive_step_parameters.max_steps);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if Array.FindIndex returns -1?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added handling of that case.

createIfNotFound : true);
}

protected override string Title { get; } = "Principia";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Mar 24, 2019
@pleroy pleroy merged commit a8a2e24 into mockingbirdnest:master Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants