Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

muse-sequencer: 3.0.2 -> 3.1pre1 #58228

Merged
merged 1 commit into from Mar 25, 2019
Merged

muse-sequencer: 3.0.2 -> 3.1pre1 #58228

merged 1 commit into from Mar 25, 2019

Conversation

Zer0-
Copy link
Contributor

@Zer0- Zer0- commented Mar 24, 2019 •
edited

Motivation for this change
  • The old version was no longer building on hydra, this fixes that.
  • Moved some dependencies to nativeBuildInputs
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • [Y] NixOS
    • [N] macOS
    • [N] other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • [Y] Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Zer0-
muse-sequencer: 3.0.2 -> 3.1pre1
76e46fc 
- The old version was no longer building on hydra, this fixes that.
- Moved some dependencies to nativeBuildInputs
@endgame
Copy link
Contributor

endgame commented Mar 24, 2019

Seems legit, but I don't have merge privs.

@7c6f434c
Copy link
Member

@endgame non-committers can use GitHub approve, though!

@7c6f434c
Copy link
Member

@GrahamcOfBorg build muse-sequencer

@endgame
Copy link
Contributor

endgame commented Mar 24, 2019

@7c6f434c I never know whether to approve the "obvious" version bumps because I have no way of testing them beyond what ofborg does already.

@7c6f434c
Copy link
Member

@GrahamcOfBorg build muse

@7c6f434c
Copy link
Member

@Zer0- hm, how did you build this on macOS?

@Zer0-
Copy link
Contributor Author

Zer0- commented Mar 24, 2019

I did not build this on osx! That is a typo!

@7c6f434c 7c6f434c merged commit 4697790 into NixOS:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zer0- @endgame @7c6f434c @GrahamcOfBorg