Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signs made by AIs do not show up at the creation time #7410

Closed
stormcone opened this issue Mar 24, 2019 · 1 comment
Closed

Signs made by AIs do not show up at the creation time #7410

stormcone opened this issue Mar 24, 2019 · 1 comment
Assignees
@nielsmh

Comments

@stormcone
Copy link
Contributor

Version of OpenTTD

20190324-master-g37b9fdc0c1

Expected result

The signs are visible

Actual result

The signs are invisible

Steps to reproduce

  • Enable the AI called "AIAI". (I chosed AIAI because it is always put it's HQ into the biggest town on the map, and puts some signs immediately there about itself so it is easier to observe the problem.)
  • Start a new game
  • Make sure the "Competitor signs and names displayed" option is checked on and the transparency settings is configured to show them
  • Open the signs list window. (It is empty)
  • Click on the biggest town in the town directory, so the main viewport will be scrolled there
  • Wait until the AI starts. It's HQ will be placed in the town with some signs, but they are not visible
  • Check the signs list window. (It has got some entries now)
  • Save the game then load it and the signs will be visible

(You can configure the AI to show the path finding steps in which case wait until it builds its first route and check the path on the screen. The signs list window will contain many more items but you can not see them on the map. Again save and load the game and they will be visible.)
@nielsmh nielsmh self-assigned this Mar 25, 2019
@nielsmh
Copy link
Contributor

nielsmh commented Mar 25, 2019

Sounds like another k-d tree bug.

PeterN added a commit to PeterN/OpenTTD that referenced this issue Mar 25, 2019
@PeterN
Fix OpenTTD#7410: Sign position/width not set on initial creation.
a9ea3a0 
Sign width was only updated when the text was changed. This seems to work for player-placed
signs as there is always a rename operation, however AIs can create a sign with text in one
go, in which case the width was never set.
@PeterN PeterN closed this as completed in 698241e Mar 25, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@PeterN @douiwby
Fix OpenTTD#7410: Sign position/width not set on initial creation. (O…
792927a 
…penTTD#7413)

Sign width was only updated when the text was changed. This seems to work for player-placed
signs as there is always a rename operation, however AIs can create a sign with text in one
go, in which case the width was never set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nielsmh nielsmh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nielsmh @stormcone