Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/gnome3: make mimeapps desktop specific #58203

Closed
wants to merge 1 commit into from
Closed

nixos/gnome3: make mimeapps desktop specific #58203

wants to merge 1 commit into from

Conversation

worldofpeace
Copy link
Contributor

They will only be applied when $XDG_CURRENT_DESKTOP == gnome 0

I've already done this for Pantheon in NixOS.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
nixos/gnome3: make mimeapps desktop specific
34dade6 
They will only be applied when $XDG_CURRENT_DESKTOP == gnome [0]

I've already done this for Pantheon in NixOS.

[0]: https://specifications.freedesktop.org/mime-apps-spec/latest/ar01s02.html
@jtojnar
Copy link
Contributor

jtojnar commented Mar 24, 2019

Will this work in flashback?

@worldofpeace
Copy link
Contributor Author

Will this work in flashback?

I see that the executable does

export XDG_CURRENT_DESKTOP="GNOME-Flashback:GNOME"

and GNOME is still in there so I think it would.

Though that should probably be tested.

@worldofpeace
Copy link
Contributor Author

worldofpeace commented Mar 24, 2019 •
edited

After some investigation, the output of

xdg-mime query default inode/directory

(inside a vm, running sessions terminal)

is always

org.gnome.baobab.desktop

with or without the change.

So I guess this wasn't working anyways?

This was referenced Jan 3, 2020
Open
Open
@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@SuperSandro2000 SuperSandro2000 marked this pull request as draft November 28, 2020 04:45
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 28, 2020
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedning hedning Awaiting requested review from hedning

@jtojnar jtojnar Awaiting requested review from jtojnar

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@worldofpeace @jtojnar @GrahamcOfBorg