Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. #7405
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterN
added
the
backport requested
Eddi-z
reviewed
Mar 24, 2019
…d saves preventing industry creation. As the information is always available from the tree ground type, unconditionally update the map array for tree tiles.
michicc
previously approved these changes
Mar 24, 2019
TrueBrain
reviewed
Mar 24, 2019
nielsmh
previously approved these changes
Mar 24, 2019
TrueBrain
approved these changes
Mar 24, 2019
TrueBrain
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7309 added WaterClass to tree tiles without performing any savegame conversion, causing problems for old saves. The information is easily rebuildable from the tree ground type, which this PR does on load unconditionally.
An alternative solution is to revert #7309 and explicitly test for trees with tree ground type shore. A branch with that version is https://github.com/PeterN/OpenTTD/commits/fix-7400