Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #7400: WaterClass for tree tiles was not converted for old saves preventing industry creation. #7405

Merged
merged 2 commits into from Mar 24, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 24, 2019

#7309 added WaterClass to tree tiles without performing any savegame conversion, causing problems for old saves. The information is easily rebuildable from the tree ground type, which this PR does on load unconditionally.

An alternative solution is to revert #7309 and explicitly test for trees with tree ground type shore. A branch with that version is https://github.com/PeterN/OpenTTD/commits/fix-7400

@PeterN PeterN added the backport requested This PR should be backport to current release (RC / stable) label Mar 24, 2019
src/saveload/afterload.cpp Outdated Show resolved Hide resolved
…d saves preventing industry creation.

As the information is always available from the tree ground type, unconditionally
update the map array for tree tiles.
michicc
michicc previously approved these changes Mar 24, 2019
nielsmh
nielsmh previously approved these changes Mar 24, 2019
@PeterN PeterN merged commit f6264e5 into OpenTTD:master Mar 24, 2019
@PeterN PeterN deleted the fix-7400b branch March 24, 2019 15:17
@TrueBrain TrueBrain added backported This PR is backported to a current release (RC / stable) and removed backport requested This PR should be backport to current release (RC / stable) labels Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported This PR is backported to a current release (RC / stable)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants