New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "[ChromeDriver] Set key modifiers with mouse actions" #16023
Conversation
@Summerlw sorry to say there was more trouble with this test. If infrastructure/ tests fail on this PR, can you check the reason and suggest the right fix? |
(Note that |
Aha. The export bot merged #15512 without the tests even having run. Taskcluster did fail but the infrastructure tests hadn't been moved then. |
@gsnedders looks like the failure isn't due to this change, but because of |
@foolip So the generate_test_api test already has an "ERROR" expectation set for firefox. And this is working as expected I think. I see in the log that the problem is from infrastructure/testdriver/actions/actionsWithKeyPressed.html - it's expecting an ERROR but it's getting either OK or FAIL (I actually can't tell which)?
|
@foolip @LukeZielinski is right, that's getting an expected ERROR. @LukeZielinski the harness is getting OK and not ERROR; the subtest is getting FAIL and not OK, hence the two unexpected results. |
@gsnedders I tried updating expectations manually based on what you said, let's see how that goes. |
490d758
to
04096d9
Compare
Already relanded in #17678. |
Landed in #15512.
Reverted in #16022.