Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghcjs-ng: unbreak #58192

Merged
merged 1 commit into from Mar 25, 2019
Merged

ghcjs-ng: unbreak #58192

merged 1 commit into from Mar 25, 2019

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Mar 24, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vaibhavsagar
Copy link
Member Author

vaibhavsagar commented Mar 24, 2019 •
edited

Currently building haskell.compiler.ghcjs84, so not yet 100% sure that this fixes the issue, but it's looking good!

Edit: haskell.compiler.ghcjs84 builds!

@vaibhavsagar
Copy link
Member Author

haskell.compiler.ghcjs also builds successfully for me.

@Ericson2314 Ericson2314 merged commit 725b549 into NixOS:master Mar 25, 2019
@vaibhavsagar vaibhavsagar deleted the unbreak-ghcjs-ng branch March 25, 2019 16:03
@FPtje FPtje mentioned this pull request Apr 15, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314 Ericson2314 approved these changes

Assignees
No one assigned
Labels
6.topic: haskell 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vaibhavsagar @Ericson2314 @GrahamcOfBorg