Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tree-wide: pkgs: /var/run -> /run #58222

Merged
merged 10 commits into from Apr 16, 2019
Merged

tree-wide: pkgs: /var/run -> /run #58222

merged 10 commits into from Apr 16, 2019

Conversation

bobvanderlinden
Copy link
Member

Fixes #51800
In response to #51918 (comment) this PR is split off from #51918. This PR only includes changes to pkgs/.

See #51918

/var/run is deprecated in tmpfiles.d and /run should be used. Currently this produces a warning every time nixos-rebuild switch runs for each service that uses tmpfiles.d with an entry for /var/run.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bobvanderlinden bobvanderlinden changed the base branch from master to staging March 24, 2019 20:07
@bobvanderlinden bobvanderlinden mentioned this pull request Mar 24, 2019
Merged
10 tasks
@Mic92
Copy link
Member

Mic92 commented Mar 25, 2019

evaluation error seems unrelated: @GrahamcOfBorg eval

@infinisil
Copy link
Member

Huh, still eval issues, that really doesn't look related, gonna try again

@GrahamcOfBorg eval

@bobvanderlinden
Copy link
Member Author

Was hoping it might help to rebase to latest staging. We'll see what @GrahamcOfBorg will do.

@bobvanderlinden
Copy link
Member Author

bobvanderlinden commented Apr 11, 2019 •
edited

@GrahamcOfBorg eval

Hopefully this works? Otherwise, could someone else give this a go?

I tried building this on OSX, but for the package it tried to build OSX is indeed not supported. I'm still not sure why grahamcofborg tried to evaluate it.

@bobvanderlinden
Copy link
Member Author

bobvanderlinden commented Apr 13, 2019 •
edited

Everything seems fine now. Made no changes to the code apart from rebasing to upstream/staging. Could someone have a look?

infinisil
infinisil approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FRidh FRidh merged commit 2b52da5 into NixOS:staging Apr 16, 2019
@bobvanderlinden bobvanderlinden deleted the var-run-pkgs branch April 16, 2019 21:40
@bobvanderlinden
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

@Phreedom Phreedom Awaiting requested review from Phreedom

@jtojnar jtojnar Awaiting requested review from jtojnar

@obadz obadz Awaiting requested review from obadz

@domenkozar domenkozar Awaiting requested review from domenkozar

@fpletz fpletz Awaiting requested review from fpletz

@rickynils rickynils Awaiting requested review from rickynils

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bobvanderlinden @Mic92 @infinisil @FRidh @GrahamcOfBorg