pythonPackages.zeep: Enable test suite for Python 3 #58154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
requested changes
Mar 23, 2019
| buildInputs = if isPy3k then [] else [ | ||
| buildInputs = [ | ||
| aiohttp | ||
| aioresponses |
There was a problem hiding this comment.
I suggest conditionally adding these to propagatedBuildInputs:
++ lib.optionals isPy3k [ aiohttp aioresponses ]
There was a problem hiding this comment.
Why did you mark this as resolved? Zeep still doesn't work on Python 2 with your proposal.
rvl
force-pushed
the
python-zeep-docheck
branch
3 times, most recently
from
eb34f83
to
9f55a30
Compare
rvl
force-pushed
the
python-zeep-docheck
branch
from
9f55a30
to
0d1305b
Compare
rvl
force-pushed
the
python-zeep-docheck
branch
from
0d1305b
to
ab930a4
Compare
|
I have better things to do than waste my time talking to you @dotlambda. |
|
@rvl I'm sorry if it felt like that. Did
offend you? If so, I'm sorry. I just meant to express "other people might be interested in Python 2 support" in a non-standard non-boring way. I'm genuinely interested to learn what you think I did wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Using pytest with Python 3 is possible now.
See also #57469.
Things done
Enabled tests for the zeep package.
Added the airoresponses package which was a dependency of the test suite.
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nix-review --run "nix-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)Assured whether relevant documentation is up to date
Fits CONTRIBUTING.md.