pkgsMusl, pkgsi686Linux, pkgsStatic: fix infinite recursion with overlays #58246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lays
Consider example:
$ nix-instantiate ./nixos -A system --arg configuration '
{
boot.isContainer = true;
nixpkgs.overlays = [ (self: super: {
nix = self.pkgsStatic.nix;
}) ];
}'
When resolving package through overlays, we figure out that
nix == self.pkgsStatic.nix
=>
nix == (import <nixpkgs> { inherit overlays; }).nix
=>
nix == (import <nixpkgs> { overlays = [(self: super: { nix = self.pkgsStatic.nix; })];}).nix
and we enter infinite recursion of nixpkgs evaluations.
The proper fix should terminate recursion by assigning self fixpoint
to inner custom package set. But I get infinite recursion somehow, so
I use `super`. It is less correct modulo deep custom overrides, but behaves
correctly for simple cases and doesn't OOM evaluator.
Fixes NixOS#57984
|
This should probably be backported to 18.09 and 19.03. |
|
I feel like the need for this exposes a weakness in the current design, but it's fine for now. |
|
@matthewbauer ok, I'll do it for 19.03, but also have to backport 83ae1ff |
|
But does this happen on 19.03? Did it happen before 83ae1ff? Maybe that commit was not really a noop and `inherit overlays` is enough there?
(I was planning to investigate in the next bit of free time, but that's not going to be today, it seems, so sorry for not being constructive.)
|
|
I see, good to know, thanks.
Then backporting a piece of 83ae1ff this depends on (i.e. without the big comment about `config` hunk) LGTM.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider example:
When resolving package through overlays, we figure out that
and we enter infinite recursion of nixpkgs evaluations.
The proper fix should terminate recursion by assigning self fixpoint
to inner custom package set. But I get infinite recursion somehow, so
I use
super. It is less correct modulo deep custom overrides, but behavescorrectly for simple cases and doesn't OOM evaluator.
Fixes #57984