Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hfsevents: Fix eval on Darwin hackage2nix config and temporarily #58216

Merged
merged 2 commits into from Mar 25, 2019
Merged

haskellPackages.hfsevents: Fix eval on Darwin hackage2nix config and temporarily #58216

merged 2 commits into from Mar 25, 2019

Conversation

srhb
Copy link
Contributor

@srhb srhb commented Mar 24, 2019

Motivation for this change

Backports the fix to hackage2nix config to not mark hfsevents unbuildable on Darwin. Also quickfixes the package set so we can get darwin-tested evals rolling again on 19.03

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti and others added 2 commits March 24, 2019 12:12
@peti @srhb
hackage2nix: drop broken entry for hfsevents
daa6f18 
The package has its meta.platforms set up correctly already in cabal2nix's
post-processing code.

Fixes NixOS#58028.

(cherry picked from commit ce5504b)
@srhb
haskellPackages.hfsevents: Fix darwin eval until next regen
91afd1c
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 24, 2019
@grahamc
Copy link
Member

grahamc commented Mar 24, 2019

This is being evaluated by ofborg after NixOS/ofborg#339 deployed, so ... good timing.

@peti peti merged commit d99ad3d into NixOS:release-19.03 Mar 25, 2019
@dtzWill dtzWill mentioned this pull request Mar 26, 2019
Merged
10 tasks
mjhoy added a commit to mjhoy/dotfiles that referenced this pull request Apr 5, 2019
@mjhoy
nixpkgs: hfsevents: fix incorrect platorms attr
3090de7 
fix @ NixOS/nixpkgs#58216 ?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basvandijk basvandijk Awaiting requested review from basvandijk

@peti peti Awaiting requested review from peti peti is a code owner

@ryantm ryantm Awaiting requested review from ryantm ryantm is a code owner

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@srhb @grahamc @peti @GrahamcOfBorg