Skip to content

systemd: update debian patches url to snapshots.debian.org #58168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2019
Merged

systemd: update debian patches url to snapshots.debian.org #58168

merged 1 commit into from
Mar 24, 2019
+5 −3

Conversation

andir
Copy link
Member

@andir andir commented Mar 23, 2019

Motivation for this change

in #56184 (comment) @qolii reported that the currently used debian patchset is gone from the mirrors. While the comment in the source suggested that we update them to a newer version in that case we should probably take a different approach in general. Having a systemd version in the tree that breaks after enough time has passed is probably a bad idea and we should use a stable source for the patches.

This change should be a no-op and safe to pick into our release branches that carry this version of systemd.

cc the usual systemd folks: @fpletz @vcunat @Mic92.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@andir
systemd: update debian patches url to snapshots.debian.org
bb821c6 
The current approach will fail when enough time has passed. We ideally
want to be reproducible even in a few years of time. So we should pick
the sources of patches wisely as otherwise we can not do that.
@andir andir requested review from fpletz and vcunat March 23, 2019 08:55
@andir andir mentioned this pull request Mar 23, 2019
Closed
10 tasks
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 23, 2019
@Mic92 Mic92 merged commit 9ceb252 into NixOS:master Mar 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92

@fpletz fpletz

@vcunat vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @Mic92 @GrahamcOfBorg