systemd: update debian patches url to snapshots.debian.org #58168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current approach will fail when enough time has passed. We ideally want to be reproducible even in a few years of time. So we should pick the sources of patches wisely as otherwise we can not do that.
10 tasks
Mic92
reviewed
Mar 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
in #56184 (comment) @qolii reported that the currently used debian patchset is gone from the mirrors. While the comment in the source suggested that we update them to a newer version in that case we should probably take a different approach in general. Having a systemd version in the tree that breaks after enough time has passed is probably a bad idea and we should use a stable source for the patches.
This change should be a no-op and safe to pick into our release branches that carry this version of systemd.
cc the usual systemd folks: @fpletz @vcunat @Mic92.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)