Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.hypothesis: 3.88.3 -> 4.7.3 #58169

Merged
merged 1 commit into from Mar 24, 2019
Merged

python.pkgs.hypothesis: 3.88.3 -> 4.7.3 #58169

merged 1 commit into from Mar 24, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Mar 23, 2019 •
edited

Motivation for this change

It looks like in 89f91cf the hash
from 4.7.3 was used and the wrong version specified.

fixes #58159 fixes #57222

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @volth @qolii

python.pkgs.hypothesis: 3.88.3 -> 4.7.3
6d8138c 
It looks like in 89f91cf the hash
from 4.7.3 was used and the wrong version specified.
@dotlambda dotlambda added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 23, 2019
@dotlambda dotlambda requested a review from FRidh as a code owner March 23, 2019 08:57
@FRidh
Copy link
Member

FRidh commented Mar 23, 2019

We should not actually do the upgrade

@dotlambda
Copy link
Member Author

Why not? I don't see many broken Python packages currently. This PR does not actually change anything but the name.

@FRidh
Copy link
Member

FRidh commented Mar 23, 2019 •
edited

Good point. Due to the accident the test I did was it seems invalid. Please target staging.

@dotlambda dotlambda changed the base branch from master to staging March 23, 2019 15:57
@dotlambda dotlambda merged commit f1c7bb9 into NixOS:staging Mar 24, 2019
@dotlambda dotlambda deleted the hypothesis-4.7.3 branch March 24, 2019 08:36
dotlambda added a commit that referenced this pull request Mar 24, 2019
@dotlambda
python.pkgs.hypothesis: 3.88.3 -> 4.7.3 (#58169)
a9c581a 
It looks like in 89f91cf the hash
from 4.7.3 was used and the wrong version specified.

(cherry picked from commit f1c7bb9)
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @FRidh @samueldr @GrahamcOfBorg