Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Giada: initialize at 0.15.4 #58233

Closed
wants to merge 3 commits into from
Closed

Giada: initialize at 0.15.4 #58233

wants to merge 3 commits into from
+79 −0

Conversation

Zer0-
Copy link
Contributor

@Zer0- Zer0- commented Mar 25, 2019

Motivation for this change

Giada is not in nixpkgs, it is one of the more capable sound looping programs on linux right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@Zer0- Zer0- changed the title Giada2 Giada: initialize at 0.15.4 Mar 25, 2019
jtojnar
jtojnar requested changes Mar 25, 2019
View reviewed changes
@Zer0-
Add recommended fixes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
b11c79c 
- change license to gplv3+
- don't override buildPhase
- move build tools into nativeBuildInputs
- other minor fixes
@Zer0-
Copy link
Contributor Author

Zer0- commented Mar 25, 2019

@jtojnar OK, Thank you for the feedback. I've made changes towards good practices.

@Zer0-
Copy link
Contributor Author

Zer0- commented May 2, 2019

"This PR breaks listing of package outputs after merging. " what does this mean?

@aanderse
Copy link
Member

@GrahamcOfBorg eval

aanderse
aanderse requested changes Jul 17, 2019
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Zer0- looks like an evaluation error. Please correct.

pkgs/applications/audio/giada/default.nix
'';
homepage = https://www.giadamusic.com;
platforms = platforms.linux;
license = lib.licenses.gpl3Plus;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove lib..

@prusnak
Copy link
Member

prusnak commented May 9, 2020

Giada has been packaged since cb0b0e9

@prusnak prusnak closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar

@aanderse aanderse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Zer0- @aanderse @prusnak @jtojnar