Giada: initialize at 0.15.4 #58233
Closed
Giada: initialize at 0.15.4 #58233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
requested changes
Mar 25, 2019
- change license to gplv3+ - don't override buildPhase - move build tools into nativeBuildInputs - other minor fixes
|
@jtojnar OK, Thank you for the feedback. I've made changes towards good practices. |
|
"This PR breaks listing of package outputs after merging. " what does this mean? |
|
@GrahamcOfBorg eval |
aanderse
requested changes
Jul 17, 2019
| ''; | ||
| homepage = https://www.giadamusic.com; | ||
| platforms = platforms.linux; | ||
| license = lib.licenses.gpl3Plus; |
|
Giada has been packaged since cb0b0e9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Giada is not in nixpkgs, it is one of the more capable sound looping programs on linux right now.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)nix path-info -Sbefore and after)