Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python beaker: 1.8.0 -> 1.10.1 fix building on hydra #58231

Merged
merged 2 commits into from Apr 2, 2019
Merged

python beaker: 1.8.0 -> 1.10.1 fix building on hydra #58231

merged 2 commits into from Apr 2, 2019

Conversation

Zer0-
Copy link
Contributor

@Zer0- Zer0- commented Mar 25, 2019 •
edited by dotlambda

Motivation for this change

  • The aim was to get this building on hydra

  • Midway I discovered a PR by Mic92 that bumps the version to 1.10.0,
    I have included some of his fixes to run tests correctly:

    • remove testing memcached (it tries to connect on import)
    • don't run external tests
    • run nosetests rather than setup.py test because that repsects NOSE_EXCLUDE

  • Let's see if the bot can build this on darwin, that was an issue in the linked PR

closes #50537

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Zer0- Zer0- requested a review from FRidh as a code owner March 25, 2019 00:49
@dotlambda
Copy link
Member

cc @Mic92

@GrahamcOfBorg build pyload python27Packages.beaker python27Packages.pyramid_beaker python36Packages.beaker python36Packages.pyramid_beaker

dotlambda
dotlambda requested changes Mar 26, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the commit messages, e.g. pythonPackages.beaker: 1.8.0 -> 1.10.1.

@Zer0-
Copy link
Contributor Author

Zer0- commented Mar 26, 2019

@dotlambda done.

@flokli
Copy link
Contributor

flokli commented Mar 26, 2019

@GrahamcOfBorg build pyload python27Packages.beaker python27Packages.pyramid_beaker python36Packages.beaker python36Packages.pyramid_beaker

@flokli flokli requested a review from dotlambda March 26, 2019 23:24
dotlambda
dotlambda requested changes Mar 28, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the new commit into the appropriate one.

@dotlambda

This comment has been minimized.

Sign in to view
@dotlambda

This comment has been minimized.

Sign in to view
@dotlambda

This comment has been minimized.

Sign in to view
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pyramid_beaker python3.pkgs.pyramid_beaker

@dotlambda
Copy link
Member

The test failure on Darwin can also be observed here: https://logs.nix.ci/?key=nixos/nixpkgs.58231&attempt_id=e1c58d4b-d361-451e-aeaf-06c6be4ac12e.

@dotlambda
Copy link
Member

@Zer0- Would you mind disabling the specific test on Darwin?

@Zer0-
pythonPackages.beaker: 1.8.0 -> 1.10.1
d94b113 
- The aim was to get this building on hydra
- Midway I discovered a PR by Mic92 that bumps the version to 1.10.0,
  I have included some of his fixes to run tests correctly:
    - remove testing memcached (it tries to connect on import)
    - don't run external tests or a failing test on darwin
            (see bbangert/beaker#166)
    - run nosetests rather than setup.py test because we need to specify
    exclude options.
@Zer0-
pythonPackages.pyramid_beaker: fix building
7819cc0 
- checkInputs rather than buildInputs
- it was complaining that py.test was not a valid command
@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pyramid_beaker python3.pkgs.pyramid_beaker

@dotlambda dotlambda merged commit 277263b into NixOS:master Apr 2, 2019
@dotlambda
Copy link
Member

backported in 4c991a7 and bd42713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

@FRidh FRidh Awaiting requested review from FRidh

@domenkozar domenkozar Awaiting requested review from domenkozar

@garbas garbas Awaiting requested review from garbas

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Zer0- @dotlambda @flokli @infinisil @GrahamcOfBorg