Skip to content

libedit: 20180525 -> 20190324 #58234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2019
Merged

libedit: 20180525 -> 20190324 #58234

merged 3 commits into from
Mar 27, 2019
+4 −5

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 25, 2019

Motivation for this change

New version.

Since determining what changed isn't easy, I made a repo with the
releases for comparing more easily.

For example, changes from version we now have to the latest
(in this PR):

https://github.com/dtzWill/libedit-releases/compare/libedit-20180525-3.1..libedit-20190324-3.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

dtzWill added 3 commits March 24, 2019 20:10
@dtzWill
libedit: 20180525 -> 20181209
f23c89a
@dtzWill
libedit: 20181209 -> 20190324
784a506
@dtzWill
libedit: No need to specify --enable-widec anymore

Verified

This commit was signed with the committer’s verified signature.
jeherve Jeremy Herve
GPG key ID: EF65CC7D9AC11920
Verified
Learn about vigilant mode
c955150
@dtzWill dtzWill mentioned this pull request Mar 25, 2019
Closed
@dtzWill
Copy link
Member Author

dtzWill commented Mar 25, 2019

Eval problem appears unrelated.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 25, 2019

@GrahamcOfBorg eval

@dtzWill dtzWill requested a review from infinisil March 26, 2019 01:12
@dtzWill dtzWill merged commit 20a331a into NixOS:staging Mar 27, 2019
@dtzWill dtzWill deleted the update/libedit-20190324 branch March 27, 2019 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dtzWill