Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slack: 3.3.7 -> 3.3.8 #58170

Merged
merged 1 commit into from Mar 24, 2019
Merged

slack: 3.3.7 -> 3.3.8 #58170

merged 1 commit into from Mar 24, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 23, 2019

Motivation for this change

#58124

Backport requested in issue.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb srhb merged commit 8cd3071 into NixOS:master Mar 24, 2019
srhb pushed a commit that referenced this pull request Mar 24, 2019
@dtzWill @srhb
slack: 3.3.7 -> 3.3.8
ff9c3f0 
Backport of #58170
(cherry picked from commit dad85bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @srhb @GrahamcOfBorg