Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

networkmanager-l2tp: 1.2.10 -> 1.2.12 #58704

Merged
merged 1 commit into from Apr 2, 2019
Merged

networkmanager-l2tp: 1.2.10 -> 1.2.12 #58704

merged 1 commit into from Apr 2, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Apr 1, 2019

Motivation for this change

https://github.com/nm-l2tp/NetworkManager-l2tp/releases/tag/1.2.12

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • Using presently! :)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill
networkmanager-l2tp: 1.2.10 -> 1.2.12
fc3e378 
Same patchups but moved to new file.
@teto
Copy link
Member

teto commented Apr 2, 2019

I ended up writing the same patch while debugging a problem with my l2tp vpn so I validate the patch.

@teto
Copy link
Member

teto commented Apr 2, 2019

as a note to l2tp vpn users the l2tp plugin expects a relative path to exists in ipsec.secrets else it fails.
if (g_str_has_prefix (all_lines[i], "include ipsec.d/ipsec.nm-l2tp.secrets")) {
one way (the only) to work around the check is to add the path to
services.strongswan.secrets = [ "ipsec.d/ipsec.nm-l2tp.secrets" ];

but the strongswan modules only accepts absolute paths so until a proper fix upstream or in the nixos module you will have to tweak either yourself see nm-l2tp/NetworkManager-l2tp#108

@obadz obadz merged commit cdf96e8 into NixOS:master Apr 2, 2019
@worldofpeace worldofpeace mentioned this pull request Jul 15, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obadz obadz Awaiting requested review from obadz

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
8.has: package (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dtzWill @teto @obadz @infinisil @GrahamcOfBorg