Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/davmail: set logging default to warn, instead of debug #58778

Merged
merged 1 commit into from Apr 6, 2019
Merged

nixos/davmail: set logging default to warn, instead of debug #58778

merged 1 commit into from Apr 6, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 2, 2019

Motivation for this change

Logs should never default to debug on a production system.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from infinisil as a code owner April 2, 2019 11:40
@infinisil infinisil merged commit 82b8ff4 into NixOS:master Apr 6, 2019
@aanderse aanderse deleted the davmail branch April 6, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil left review comments

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @infinisil @GrahamcOfBorg