Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pyogg: 0.6.6a1 -> 0.6.9a1 #58746

Merged
merged 1 commit into from Apr 3, 2019
Merged

pythonPackages.pyogg: 0.6.6a1 -> 0.6.9a1 #58746

merged 1 commit into from Apr 3, 2019

Conversation

pmiddend
Copy link
Contributor

@pmiddend pmiddend commented Apr 2, 2019

Motivation for this change

This is both an update and a bug-fix (see the substitute changes).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@pmiddend pmiddend requested a review from FRidh as a code owner April 2, 2019 07:19
@pmiddend
Copy link
Contributor Author

pmiddend commented Apr 2, 2019

@dotlambda I added a patch which seems to work. Is this okay?

@dotlambda
Copy link
Member

It's a lot easier that that. Just use

patches = [
  (substituteAll {
    src = ./pyogg-paths.patch;
    flacLibPath = "${flac.out}/lib/libFLAC${stdenv.hostPlatform.extensions.sharedLibrary}";
    ...
  })
];

@pmiddend
Copy link
Contributor Author

pmiddend commented Apr 2, 2019

@dotlambda Ahh, very nice. Fixed.

@dotlambda
Copy link
Member

@GrahamcOfBorg build python2.pkgs.pyogg python3.pkgs.pyogg

@dotlambda dotlambda merged commit 2424a7c into NixOS:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda left review comments

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pmiddend @dotlambda @GrahamcOfBorg