Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manual: fix the hacking section #2756

Closed
wants to merge 1 commit into from
Closed

manual: fix the hacking section #2756

wants to merge 1 commit into from

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Apr 4, 2019

The hacking section of the manual says to run configurePhase before running make, but configurePhase does not exist. Running ./configure without any arguments worked for me.

@edolstra
Copy link
Member

edolstra commented Apr 4, 2019 •
edited

That's very strange, since configurePhase absolutely should exist (it's defined by stdenv). Note that it does a bit more than just call ./configure. In particular it also passes the right flags to the configure script.

@kalbasit
Copy link
Member Author

kalbasit commented Apr 4, 2019

Interesting! It works if I run command nix-shell and I do get a configurePhase. I guess this is an issue in zsh-nix-shell, which I use to get a native zsh nix-shell.

@kalbasit kalbasit closed this Apr 4, 2019
@kalbasit kalbasit deleted the patch-1 branch April 4, 2019 15:28
@edolstra
Copy link
Member

edolstra commented Apr 5, 2019

Ah yes, shell functions like configurePhase only work if you're in the same (bash) shell that sourced the stdenv setup script.

@kalbasit
Copy link
Member Author

kalbasit commented Apr 5, 2019

I see. It makes sense now. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kalbasit @edolstra