vapoursynth: split python module out #58859
Conversation
|
cc @rnhmjoj (maintainer) |
GrahamcOfBorg
added
6.topic: python
8.has: package (new)
tadeokondrak
force-pushed
the
vapoursynth-fix-vspipe
branch
2 times, most recently
from
c7f6f37 to
c331d9f
Compare
|
I can't seem to get Edit: Thinking about it more, it makes sense that it's in the python output (it evaluates python scripts). Might be a bit unintuitive, but still better than the previous behaviour of it not working |
GrahamcOfBorg
added
the
11.by: package-maintainer
|
The only way I've found to load plugins is to create an environment with I tested my setup for frame interpolation in mpv and looks good. I've never used vspipe directly, so you probably know better than me. |
| @@ -21,7 +21,7 @@ stdenv.mkDerivation rec { | |||
| sha256 = "09fj4k75cksx1imivqfyr945swlr8k392kkdgzldwc4404qv82s6"; | |||
| }; | |||
|
|
|||
| nativeBuildInputs = [ pkgconfig autoreconfHook nasm ]; | |||
| nativeBuildInputs = [ pkgconfig autoreconfHook nasm python3 makeWrapper ]; | |||
There was a problem hiding this comment.
You now have two separate python3 executables in $PATH in the builder. Given the libraries included in the one a couple lines down, I'm assuming that one is actually used during the build process, not this one?
Does vapoursynth's Python module have dependencies on any non-standard modules?
There was a problem hiding this comment.
This python3 seems to be needed to get the toPythonPath in the wrapProgram call below to work.
Does vapoursynth's Python module have dependencies on any non-standard modules?
No, the current ones are only used during the build.
| moveToOutput lib/${python3.libPrefix} $python | ||
| moveToOutput bin/vspipe $python | ||
| wrapProgram $python/bin/vspipe \ | ||
| --prefix PYTHONPATH : $(toPythonPath $python) |
There was a problem hiding this comment.
Use wrapPythonPrograms from python3.pkgs.wrapPython, instead.
There was a problem hiding this comment.
This doesn't seem to work with binary programs.
There was a problem hiding this comment.
It does work with binary programs (it iterally calls wrapProgram under the hood), but it relies on $pythonPath being set in the builder. This happens automatically for buildPythonPackage, but not for stdenv.mkDerivation.
You could either set pythonPath appropriately, or actually use buildPythonPackage, which would possibly be appropriate given it provides a Python library. I suspect if you do that and specify format = "other";, it may Just Work (tm) and you can drop the manual wrapping entirely, but I haven't tested it 🤷♂️.
tadeokondrak
force-pushed
the
vapoursynth-fix-vspipe
branch
from
c331d9f to
d6ca994
Compare
previously, vapoursynth was not a python module in how most python libraries are in nixpkgs. it would only work as part of a library or other program, and not with its included `vspipe` program. this fixes it by adding a new output for its python module and uses toPythonModule to allow it to work standalone, and without conflicting with other python packages in a nix-shell
tadeokondrak
force-pushed
the
vapoursynth-fix-vspipe
branch
from
d6ca994 to
37b5844
Compare
Motivation for this change
Previously, vapoursynth was not a python module in how most python libraries are in nixpkgs. It would only work as part of a library or other program, and its included
vspipeprogram was broken.There still isn't a convenient way to load plugins (it relies on a global search path on other distros), which I plan to address in a future PR, probably by adding a
vapoursynth.withPluginsfunction.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nix-review --run "nix-review wip"./result/bin/)vspipempvwith vapoursynth enablednix path-info -Sbefore and after)