Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pytest-rerunfailures: 6.0 -> 7.0 #58710

Merged
merged 1 commit into from Apr 2, 2019
Merged

Conversation

Meptl
Copy link
Contributor

@Meptl Meptl commented Apr 1, 2019

Motivation for this change

Failing hydra build for 19.03. Figured I'd update to the package in the process.
Python3: https://hydra.nixos.org/build/90113585
Python2: https://hydra.nixos.org/build/90308802

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Tests
  • nix-build -A pytest-rerunfailures
  • (Looks to be the only expression to use this package) nix-build -A tmuxp
Click to see nix-shell testing

shell.nix (Also modify for python2)

{ pkgs ? import <nixpkgs> {} }:

pkgs.stdenv.mkDerivation rec {
  name = "xonsh";
  buildInputs = with pkgs; [
    tmuxp
    python3Packages.pytest
    python3Packages.pytest-rerunfailures
  ];
}

test_rerun.py

import pytest
import time

def test_foo():
    assert int(time.time()) % 10 in (1)
nix-shell --pure -I nixpkgs=/path/to/nixpkgs 
pytest --reruns 10 --reruns-delay 1
tmuxp --version  # I don't know how to use tmuxp
tmuxp --help
Additional Notes

https://pypi.org/project/pytest-rerunfailures/#id1

@xeji
Copy link
Contributor

xeji commented Apr 2, 2019

@GrahamcOfBorg build python37Packages.pytest-rerunfailures python27Packages.pytest-rerunfailures

@xeji xeji merged commit 6fa01d5 into NixOS:master Apr 2, 2019
xeji pushed a commit that referenced this pull request Apr 2, 2019
@xeji
Copy link
Contributor

xeji commented Apr 2, 2019

Thank you.
Backported to 19.03 in de216e6 /cc #56826

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants