Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Server reports CRR_AUTOCLEAN instead of CRR_MANUAL to admin port #7439

Closed
ldpl opened this issue Mar 29, 2019 · 2 comments
Closed

Server reports CRR_AUTOCLEAN instead of CRR_MANUAL to admin port #7439

ldpl opened this issue Mar 29, 2019 · 2 comments

Comments

@ldpl
Copy link
Contributor

ldpl commented Mar 29, 2019 •
edited
Loading

1.9.0-RC2

When company is reset by console command (e.g. reset_company 1) server reports reason 1 (autoclean) instead of 0 (CRR_MANUAL). Because CmdCompanyCtrl expects reason to be in p2 but command is marked as CMD_CLIENT_ID so DoCommandP sets p2 as CLIENT_ID_SERVER when it's zero (and CRR_MANUAL is).

There is an old bug #4804 and as far as I can tell by code it wasn't actually fixed in r23031 (din't try runnig tho).
@EgyLynx
Copy link

EgyLynx commented Apr 3, 2019

Are that happened also 1.9.0?

Sorry, something went wrong.

@nielsmh
Copy link
Contributor

nielsmh commented Apr 4, 2019

@EgyLynx Yes this will also be happening in 1.9.0, and any other version. The bug was not fixed and is many years old.

Sorry, something went wrong.

glx22 added a commit to glx22/OpenTTD that referenced this issue Apr 4, 2019
@glx22
Fix OpenTTD#7439: don't overwrite CompanyRemoveReason with ClientID
50242f4
glx22 added a commit to glx22/OpenTTD that referenced this issue Apr 4, 2019
@glx22
Fix OpenTTD#7439: don't overwrite CompanyRemoveReason with ClientID
23497e8
@glx22 glx22 closed this as completed in a1e492d Apr 5, 2019
PeterN pushed a commit to PeterN/OpenTTD that referenced this issue Apr 8, 2019
@glx22 @PeterN
Fix OpenTTD#7439: don't overwrite CompanyRemoveReason with ClientID (O…
5126f7e 
…penTTD#7465)
PeterN pushed a commit that referenced this issue Apr 8, 2019
@glx22 @PeterN
Fix #7439: don't overwrite CompanyRemoveReason with ClientID (#7465)
abc0325
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@glx22 @douiwby
Fix OpenTTD#7439: don't overwrite CompanyRemoveReason with ClientID (O…
590e1ac 
…penTTD#7465)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ldpl @nielsmh @EgyLynx