Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openmpi: 4.0.0 -> 4.0.1 #58757

Merged
merged 2 commits into from May 27, 2019
Merged

openmpi: 4.0.0 -> 4.0.1 #58757

merged 2 commits into from May 27, 2019

Conversation

markuskowa
Copy link
Member

@markuskowa markuskowa commented Apr 2, 2019 •
edited

Motivation for this change

regular update

Changelog: https://github.com/open-mpi/ompi/blob/v4.0.x/NEWS

Things done
  • remove upstream patch
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member Author

markuskowa commented Apr 2, 2019 •
edited

@GrahamcOfBorg build openmpi
@GrahamcOfBorg build scalapack
@GrahamcOfBorg build python3Packages.mpi4py
@GrahamcOfBorg build lammps-mpi
@GrahamcOfBorg build dl-poly-classic-mpi
@GrahamcOfBorg build siesta-mpi

@markuskowa
Copy link
Member Author

markuskowa commented Apr 2, 2019 •
edited

mpi4py fails again due to outdated symbols.
openmpi now fails on darwin:

server/pmix_server_ops.c:3432:19: error: use of undeclared identifier 'CLOCK_MONOTONIC'
    clock_gettime(CLOCK_MONOTONIC, &tp);

@markuskowa markuskowa requested a review from FRidh as a code owner April 9, 2019 09:07
@FRidh
Copy link
Member

FRidh commented May 12, 2019

status?

@markuskowa
Copy link
Member Author

@FRidh I did not have time to work on this lately. The main blocker here is the build failure on darwin (which I can not really debug). I may put this on hold until 4.0.2 is out, which hopefully solves the darwin problem.

@orivej
Copy link
Contributor

orivej commented May 27, 2019

Darwin should have CLOCK_MONOTONIC since d69cc77 which updates its Libc package from 1082.50.1 to 1158.50.2 (https://reviews.llvm.org/D27429).

@orivej
Copy link
Contributor

orivej commented May 27, 2019

@GrahamcOfBorg build python3Packages.mpi4py

orivej
orivej approved these changes May 27, 2019
View reviewed changes
Copy link
Contributor

@orivej orivej left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have checked on a mac that with this PR on top of the current nixpkgs python3.pkgs.mpi4py builds (and passes its tests).

@markuskowa
Copy link
Member Author

Did a rebase (unfortunatley the ofborg darwin builders seem to have a general issue right now).
@orivej thanks for clearing up the darwin question. With that the PR is ready to be merged.

@orivej-nixos orivej-nixos merged commit 4448d04 into NixOS:master May 27, 2019
@markuskowa markuskowa deleted the upd-openmpi branch May 27, 2019 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orivej orivej orivej approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (update) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@markuskowa @FRidh @orivej @GrahamcOfBorg @orivej-nixos