Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openjdk: disable hotspot os version check #58720

Closed
wants to merge 1 commit into from
Closed

openjdk: disable hotspot os version check #58720

wants to merge 1 commit into from

Conversation

astro
Copy link
Contributor

@astro astro commented Apr 1, 2019 •
edited

Motivation for this change

This fixes the build on Linux 5.*

Related: d780e48 #8090

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@astro
openjdk: disable hotspot os version check
15510bc 
This fixes the build on Linux 5.*
@FRidh
Copy link
Member

FRidh commented Nov 3, 2019

Is this still needed?

@NeQuissimus
Copy link
Member

I doubt it, I use JDK8 on Linux 5.x every day :)

@NeQuissimus NeQuissimus closed this Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@multun multun multun approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@astro @FRidh @NeQuissimus @multun @GrahamcOfBorg