Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latexrun package #58939

Merged
merged 1 commit into from Apr 5, 2019
Merged

Add latexrun package #58939

merged 1 commit into from Apr 5, 2019

Conversation

Lucus16
Copy link
Contributor

@Lucus16 Lucus16 commented Apr 3, 2019

Motivation for this change

latexrun is a useful tool to convert tex files to pdfs without writing complicated makefiles. Upstream has no version information and it is unlikely the creator will ever release another version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

pkgs/tools/typesetting/tex/latexrun/default.nix Outdated Show resolved Hide resolved
pkgs/tools/typesetting/tex/latexrun/default.nix Outdated Show resolved Hide resolved
@@ -0,0 +1,27 @@
{ stdenvNoCC, fetchFromGitHub, python3 }:

stdenvNoCC.mkDerivation {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if this would still need to use buildPythonApplication. cc @FRidh

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried that first, but it complained about needing a setup.py. Since this package doesn't require any libraries other than the standard library, I figured this is fine.

@Lucus16
Copy link
Contributor Author

Lucus16 commented Apr 4, 2019

Is there something else I should do before this gets merged or are we just waiting on @FRidh ?

@veprbl
Copy link
Member

veprbl commented Apr 4, 2019

@Lucus16 We are just waiting if anyone else has comments. No action is required at this time.

@veprbl veprbl merged commit 21d1b19 into NixOS:master Apr 5, 2019
@veprbl
Copy link
Member

veprbl commented Apr 5, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants