Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: dee9eee6b94f
Choose a base ref
...
head repository: GlasgowEmbedded/glasgow
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 7c7ded1a8bb0
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Apr 3, 2019

  1. applet.audio.yamaha_opl: mark as broken. 

    Looks like the changes in e59730f disturbed a fragile balance
between coroutine scheduling and buffering in the hardware.
To fix this, the applet likely requires an explicit feedback path
between the playback and record coroutines, and/or further rework
of pipelining.
    @whitequark
    whitequark committed Apr 3, 2019
    1
    Copy the full SHA
    7c7ded1 View commit details
Showing with 4 additions and 0 deletions.
  1. +4 −0 software/glasgow/applet/audio/yamaha_opl/__init__.py
4 changes: 4 additions & 0 deletions software/glasgow/applet/audio/yamaha_opl/__init__.py
View file
Original file line number Diff line number Diff line change
@@ -732,9 +732,13 @@ async def serve(self):


class AudioYamahaOPLApplet(GlasgowApplet, name="audio-yamaha-opl"):
preview = True
logger = logging.getLogger(__name__)
help = "drive and record Yamaha OPL* FM synthesizers"
description = """
WARNING: Since commit e59730fb this applet has a serious problem with buffer overruns.
It will need to be reworked.
Send commands and record digital output from Yamaha OPL* series FM synthesizers. The supported
chips are:
* YM3526 (OPL)