Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opam: put the whole /run/current-system/sw as well in OPAM_USER_PATH_RO #58951

Closed
wants to merge 1 commit into from

Conversation

tg-x
Copy link
Member

@tg-x tg-x commented Apr 3, 2019

Motivation for this change

#57118 did not entirely fix the issue, /run/current-system/sw/lib is required as well otherwise opam won't find libraries there.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tg-x
Copy link
Member Author

tg-x commented Apr 3, 2019

cc @srhb

@srhb
Copy link
Contributor

srhb commented Apr 4, 2019

Again, I've little knowledge on the opam world, so soliciting reviews from others more knowledgeable (check the commit logs eg.) might prove helpful!

I will note that this sounds suspect to me, and sort of antithetical. See eg. https://nixos.wiki/wiki/FAQ#I_installed_a_library_but_my_compiler_is_not_finding_it._Why.3F

Can you explain why this is something we want? As I understood the other issue, it was preventing some use cases from even accessing libraries for builds made in a declarative fashion, but this seems far more prone to allowing accidental state leaks.

@tg-x
Copy link
Member Author

tg-x commented Apr 4, 2019

This is the same issue that opam build does not find libraries to link with in /run/current-system/sw/lib which is in LDFLAGS and not included in the sandbox.

What kind of state leaks do you mean? etc?
We could exclude /run/current-system/sw/etc if you mean that, and include bin, sbin, lib, share

@matthewbauer
Copy link
Member

/cc @xplat

@stale
Copy link

stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2020
@SuperSandro2000
Copy link
Member

@tg-x is this still relevant?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 18, 2021
@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@Artturin Artturin closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants