Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eduke32: 20150420 -> 20190330 #58933

Merged
merged 1 commit into from
Apr 5, 2019
Merged

eduke32: 20150420 -> 20190330 #58933

merged 1 commit into from
Apr 5, 2019
+50 −48

Conversation

peterhoeg
Copy link
Member

Also:

  • use makeWrapper instead of a custom binary wrapper
  • general minor cleanups

Cc: @svanderburg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@peterhoeg
eduke32: 20150420 -> 20190330
2827e49 
Also:

 - use makeWrapper instead of a custom binary wrapper
 - general minor cleanups
@GrahamcOfBorg GrahamcOfBorg added the 8.has: package (new) This PR adds a new package label Apr 3, 2019
@infinisil infinisil added the 8.has: package (update) This PR updates a package to a newer version label Apr 4, 2019
@svanderburg svanderburg merged commit e129404 into NixOS:master Apr 5, 2019
@peterhoeg peterhoeg deleted the u/eduke32 branch April 7, 2019 08:55
@peterhoeg peterhoeg restored the u/eduke32 branch April 7, 2019 14:43
@peterhoeg peterhoeg deleted the u/eduke32 branch April 8, 2019 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svanderburg svanderburg

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 8.has: package (update) This PR updates a package to a newer version 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@peterhoeg @svanderburg @infinisil @GrahamcOfBorg