New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump patchelf and patchelfUnstable to 0.10 #58715
Conversation
785d4da
to
605f9ec
Compare
This PR still didn't make tests on non-musl platforms working, but they were broken before anyway (for Unstable; they were disabled for regular version.) And I am sorry for the mess with assignees, I incorrectly pushed a master branch to staging that triggered lots of unrelated assignees. |
@infinisil how should I proceed here? I imagine we should validate that it doesn't break any package in the tree. How? |
@grahamc (sorry if you are the wrong person to ask but it's been a month for the PR) how can we proceed with the change? I was told that there should be a new job to validate the version bump because it's so invasive but I have no details how to add it etc. so I would love to get some guidance. If you are the wrong person to ask, perhaps you could tag the right ones. Thanks. |
@infinisil thanks for the heads up. It would be nice to, before I resolve conflicts, know how we proceed with CI (and whether we do it; I see that the other patch was merged no questions asked). |
605f9ec
to
63f874f
Compare
The recipe is copied from patchelfUnstable.
Sorry, made the same mistake forgetting this PR is in staging branch. Fix incoming... |
63f874f
to
36e452d
Compare
@GrahamcOfBorg build patchelf |
36e452d
to
59bed0a
Compare
@domenkozar for some reason, now that I tried to run tests for unstable, they worked on standard platform. So I've dropped the patch that disabled the tests for non-musl platforms from the series. Note that tests are still failing on non-musl for default.nix but that's not a regression since they failed before the bump too. |
@GrahamcOfBorg build patchelf patchelfUnstable |
@GrahamcOfBorg build patchelf |
Sadly OfBorg won't build these, I'm merging to staging so that this will hit 19.09 |
This PR caused a weird issue: #69213 I don't know more ATM, ideas are welcome. BTW, this missed 19.09, it was too late. |
I downgraded the default for now; see the linked ticket(s) for details. |
No description provided.