Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump patchelf and patchelfUnstable to 0.10 #58715

Merged
merged 4 commits into from Sep 9, 2019

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Apr 1, 2019

No description provided.

@booxter
Copy link
Contributor Author

booxter commented Apr 2, 2019

This PR still didn't make tests on non-musl platforms working, but they were broken before anyway (for Unstable; they were disabled for regular version.)

And I am sorry for the mess with assignees, I incorrectly pushed a master branch to staging that triggered lots of unrelated assignees.

@peti peti removed their request for review April 2, 2019 07:49
@infinisil infinisil mentioned this pull request Apr 3, 2019
@booxter
Copy link
Contributor Author

booxter commented Apr 7, 2019

@infinisil how should I proceed here? I imagine we should validate that it doesn't break any package in the tree. How?

@booxter
Copy link
Contributor Author

booxter commented May 2, 2019

@grahamc (sorry if you are the wrong person to ask but it's been a month for the PR) how can we proceed with the change? I was told that there should be a new job to validate the version bump because it's so invasive but I have no details how to add it etc. so I would love to get some guidance. If you are the wrong person to ask, perhaps you could tag the right ones. Thanks.

@booxter
Copy link
Contributor Author

booxter commented May 29, 2019

@infinisil thanks for the heads up. It would be nice to, before I resolve conflicts, know how we proceed with CI (and whether we do it; I see that the other patch was merged no questions asked).

@veprbl veprbl mentioned this pull request Jul 2, 2019
10 tasks
@ttuegel ttuegel removed their request for review August 6, 2019 13:35
@booxter booxter requested a review from nbp as a code owner August 30, 2019 20:06
@ofborg ofborg bot added 6.topic: emacs 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: lua 6.topic: nixos labels Aug 30, 2019
@booxter
Copy link
Contributor Author

booxter commented Aug 30, 2019

Sorry, made the same mistake forgetting this PR is in staging branch. Fix incoming...

@domenkozar
Copy link
Member

@GrahamcOfBorg build patchelf

@booxter
Copy link
Contributor Author

booxter commented Sep 3, 2019

@domenkozar for some reason, now that I tried to run tests for unstable, they worked on standard platform. So I've dropped the patch that disabled the tests for non-musl platforms from the series.

Note that tests are still failing on non-musl for default.nix but that's not a regression since they failed before the bump too.

@domenkozar
Copy link
Member

@GrahamcOfBorg build patchelf patchelfUnstable

@domenkozar
Copy link
Member

@GrahamcOfBorg build patchelf

@domenkozar
Copy link
Member

Sadly OfBorg won't build these, I'm merging to staging so that this will hit 19.09

@domenkozar domenkozar merged commit 41ad32f into NixOS:staging Sep 9, 2019
@vcunat
Copy link
Member

vcunat commented Sep 21, 2019

This PR caused a weird issue: #69213 I don't know more ATM, ideas are welcome.

BTW, this missed 19.09, it was too late.

vcunat added a commit that referenced this pull request Sep 22, 2019
This is a partial revert of #58715.  Bumping the default caused problems
described in #69213.  I tested that the vscode corruption happened even
with the 0.10 pre-release, so I'm keeping patchelfUnstable on 0.10
(patchelfUnstable shouldn't cause a large rebuild anyway)
@vcunat
Copy link
Member

vcunat commented Sep 22, 2019

I downgraded the default for now; see the linked ticket(s) for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants