Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apache Flume Initial Package 1.9.0 #58728

Closed
wants to merge 2 commits into from
Closed

Apache Flume Initial Package 1.9.0 #58728

wants to merge 2 commits into from

Conversation

polynomial
Copy link
Contributor

Motivation for this change

We use Apache Flume in production and are migrating everything to NixOS. I will write a module next, but this gets me a working Apache Flume jar, which is a great first step!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@polynomial polynomial mentioned this pull request May 1, 2019
Closed
10 tasks
JohnAZoidberg
JohnAZoidberg reviewed Jun 2, 2019
View reviewed changes
pkgs/top-level/all-packages.nix
@@ -8580,6 +8580,9 @@ in
apacheKafka_2_1 = callPackage ../servers/apache-kafka { majorVersion = "2.1"; };
apacheKafka_2_2 = callPackage ../servers/apache-kafka { majorVersion = "2.2"; };

apacheFlume = apacheFlume_1_9_0;
apacheFlume_1_9_0 = callPackage ../servers/apache-flume { majorVersion = "1.9.0"; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think there will be reasons to keep multiple versions of flume?
It does not seem like there are multiple maintained at the same time.
If that's not the case, it'd be better not to have to maintain multiple versions for us.

pkgs/servers/apache-flume/default.nix
homepage = http://flume.apache.org;
description = "Flume is a distributed, reliable, and available service for efficiently collecting, aggregating, and moving large amounts of log data.";
license = licenses.asl20;
maintainers = [ ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be willing to look after this package, i.e. be maintainer?

pkgs/servers/apache-flume/default.nix
'';

meta = with stdenv.lib; {
homepage = http://flume.apache.org;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = http://flume.apache.org;
homepage = "https://flume.apache.org";

We'll deprecate unquoted URL syntax, once RFC 45 is approved. Also their site supports https.

pkgs/servers/apache-flume/default.nix
wrapProgram $out/bin/flume-ng \
--set FLUME_HOME "$out" \
--set JAVA_HOME "${jre}"
chmod +x $out/bin\/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure wrapProgram already marks its output as executable. Please try to remove it.

pkgs/servers/apache-flume/default.nix

stdenv.mkDerivation rec {
version = "${flumeVersion}";
name = "apache-flume-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name = "apache-flume-${version}";
pname = "apache-flume";

pname appends the version name on its own.

pkgs/servers/apache-flume/default.nix
with versionMap.${majorVersion};

stdenv.mkDerivation rec {
version = "${flumeVersion}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
version = "${flumeVersion}";
version = flumeVersion;

No string quoting necessary here :)

pkgs/servers/apache-flume/default.nix

meta = with stdenv.lib; {
homepage = http://flume.apache.org;
description = "Flume is a distributed, reliable, and available service for efficiently collecting, aggregating, and moving large amounts of log data.";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow https://nixos.org/nixpkgs/manual/#sec-standard-meta-attributes

@polynomial polynomial force-pushed the flume branch 2 times, most recently from 8350d1f to 54e22ec Compare July 2, 2019 18:02
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Oct 3, 2020
@stale
Copy link

stale bot commented Jun 7, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 7, 2021
@auroraanna
Copy link
Contributor

@polynomial why didn't you respond to the suggestions?

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Mar 31, 2022
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Aug 25, 2022 •
edited

Closing due to being stale and no response from the author in a longer time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnAZoidberg JohnAZoidberg JohnAZoidberg left review comments

@infinisil infinisil Awaiting requested review from infinisil

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: nixos 8.has: module (update) 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@polynomial @auroraanna @SuperSandro2000 @JohnAZoidberg @ryantm @GrahamcOfBorg