Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.DBDOracle: init at 1.76 #58726

Merged
merged 1 commit into from Apr 2, 2019
Merged

perlPackages.DBDOracle: init at 1.76 #58726

merged 1 commit into from Apr 2, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Apr 2, 2019 •
edited

Motivation for this change

Missing from nixpkgs 馃槥

I ran a perl script which used this code to successfully connect to an Oracle database 馃憤
PS. I'd really love a backport to 19.03 after it has been released.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse
Copy link
Member Author

aanderse commented Apr 2, 2019

@volth Anything I'm missing here?

@xeji
Copy link
Contributor

xeji commented Apr 2, 2019

@GrahamcOfBorg build perl528Packages.DBDOracle perldevelPackages.DBDOracle

@aanderse
Copy link
Member Author

aanderse commented Apr 2, 2019

@xeji depends on the Oracle instantclient package so no go for the bot.

@xeji
Copy link
Contributor

xeji commented Apr 2, 2019

I see, thanks.

@xeji xeji merged commit 427320c into NixOS:master Apr 2, 2019
@aanderse
Copy link
Member Author

aanderse commented Apr 2, 2019

Thanks for the commit!

@aanderse aanderse deleted the dbi-oracle branch April 2, 2019 21:16
@aanderse aanderse mentioned this pull request Apr 11, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @xeji @GrahamcOfBorg