Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: add plugins deoplete-fish, NeoSolarized, vim-choosewin, and vim-fish #58846

Merged
merged 5 commits into from Apr 22, 2019

Conversation

malob
Copy link
Member

@malob malob commented Apr 2, 2019

Motivation for this change

Needed these vim plugins for my Neovim config and they weren't already in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! However please make sure your commits actually do fit contributing.md.

In particular, you should have one commit for each added plugin. Each in the form

vimPlugins.deoplete-fish: init at 2018-09-15

This can be a bit annoying to achieve with vim plugins since you can only re-generate all plugins at once. But it is possible. The easiest way to do it is like this:

  • make sure you're working from the latest nixpkgs master, as merge conflicts are likely
  • first make sure all other Plugins are up to date by executing ./update.py once without having made any modifications. Commit that change with the commit message vimPlugins: update.
  • add your first plugin to vim-plugin-names. Add overrides if necessary. Re-execute ./update.py which should now only generate the entry for that plugin. Commit your changes as vimPlugins.plugin-name: init at <ininital version>.
  • repeat for your other plugins

@malob
Copy link
Member Author

malob commented Apr 21, 2019

Thanks for the feedback, and sorry I missed that. I think all the commits should be in order now.

@timokau
Copy link
Member

timokau commented Apr 22, 2019

LGTM, thank you :)

@timokau timokau merged commit 154f36d into NixOS:master Apr 22, 2019
@malob malob deleted the new-vim-plugins branch April 22, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants