Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charliecloud: init at 0.9.8 #58936

Merged
merged 1 commit into from Apr 4, 2019
Merged

charliecloud: init at 0.9.8 #58936

merged 1 commit into from Apr 4, 2019

Conversation

bzizou
Copy link
Contributor

@bzizou bzizou commented Apr 3, 2019

Motivation for this change

charliecloud is used into our supercomputing center

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markuskowa
Copy link
Member

markuskowa commented Apr 4, 2019 •
edited

@GrahamcOfBorg build charliecloud

@markuskowa
Copy link
Member

@bzizou can you please setup your editor such that it removes trailing white spaces at the end of the line.
The folder lib/charliecloud contains two sub folders, examples and tests, which would fit better in share/charliecloud.

@bzizou
Copy link
Contributor Author

bzizou commented Apr 4, 2019

Thank you, I added this into my vimrc :-)

highlight ExtraWhitespace ctermbg=red guibg=red
match ExtraWhitespace /\s\+$/

And I moved the sub folders examples and test into share/charliecloud

@markuskowa
Copy link
Member

Looks good, thank you!

@markuskowa markuskowa merged commit 3eecb29 into NixOS:master Apr 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markuskowa markuskowa markuskowa approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bzizou @markuskowa @GrahamcOfBorg