Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postman: 6.7.3 -> 7.0.7 #58944

Merged
merged 3 commits into from Apr 3, 2019
Merged

postman: 6.7.3 -> 7.0.7 #58944

merged 3 commits into from Apr 3, 2019

Conversation

d10n
Copy link
Contributor

@d10n d10n commented Apr 3, 2019 •
edited

Bundles #58502
Also bundled: fixing the icon detection on my system

Motivation for this change

To squelch the annoying red "upgrade available" dot

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
    • CentOS6
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@d10n
postman: 6.7.3 -> 7.0.6
16a416b
@d10n
postman: 7.0.6 -> 7.0.7
5dbc956
@d10n
postman: Link icon to $out/share/icons root
dd47ef7 
At least on the version of Gnome shipping with CentOS 6, the icon in
$out/share/icons/hicolor/128x128/apps is not picked up, but the icon in
$out/share/icons does get picked up.
@xeji xeji mentioned this pull request Apr 3, 2019
Closed
10 tasks
@xeji xeji changed the title postman: 7.0.6 -> 7.0.7 postman: 6.7.3 -> 7.0.7 Apr 3, 2019
@xeji
Copy link
Contributor

xeji commented Apr 3, 2019

changed title to reflect content

@xeji
Copy link
Contributor

xeji commented Apr 3, 2019

unfree package, build checked locally

@xeji xeji merged commit 8775cea into NixOS:master Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@d10n @xeji @GrahamcOfBorg