Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] Security backports for html-proofer and gollum #58770

Merged
merged 3 commits into from Apr 2, 2019
Merged

[18.09] Security backports for html-proofer and gollum #58770

merged 3 commits into from Apr 2, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 2, 2019 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos primeos added 1.severity: security 8.has: port to stable A PR already has a backport to the stable release. labels Apr 2, 2019
@primeos primeos self-assigned this Apr 2, 2019
@primeos
Copy link
Member Author

primeos commented Apr 2, 2019

I've tested this inside a VM and everything was fine. I'll merge it without the tests as the evaluation is already broken anyway (https://gist.github.com/GrahamcOfBorg/80c332fa27b774e7fc7f5f16512a0796, d22d43a#r32999972).

@primeos primeos merged commit e2a1fd1 into NixOS:release-18.09 Apr 2, 2019
@primeos primeos mentioned this pull request Apr 2, 2019
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
1.severity: security 8.has: port to stable A PR already has a backport to the stable release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @alyssais