Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.zarith: 1.7 -> 1.8 #58932

Merged
merged 2 commits into from Apr 12, 2019
Merged

ocamlPackages.zarith: 1.7 -> 1.8 #58932

merged 2 commits into from Apr 12, 2019

Conversation

vbgl
Copy link
Contributor

@vbgl vbgl commented Apr 3, 2019

Motivation for this change

Major update, including compatibility with OCaml 4.08.

As this breaks the bignum library, I’ve removed it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor Author

vbgl commented Apr 3, 2019

@GrahamcOfBorg build framac fstar google-drive-ocamlfuse jackline opa why3

@vbgl vbgl merged commit 1c84236 into NixOS:master Apr 12, 2019
@vbgl vbgl deleted the ocaml-zarith-1.8 branch April 12, 2019 14:48
@thoughtpolice
Copy link
Member

thoughtpolice commented Apr 22, 2019 •
edited

@vbgl Can you explain this change? Why was 564653f effectively reverted by this PR? The justification is laid out in commit: this breaks downstream projects which depend on CAML_LD_LIBRARY_PATH containing dllzarith.so, of which I maintain one, and buildOcaml fixes this use case by correctly propagating that in its setup-hook

I just tested the following patch after reverting 1c84236 and it seems to work just fine. Nothing else was necessary to update zarith to 1.8 while using buildOcaml, and my project can now build its lem dependency successfully. Can we revert this PR and re-apply my (and the following) change?

diff --git a/pkgs/development/ocaml-modules/zarith/default.nix b/pkgs/development/ocaml-modules/zarith/default.nix
index d91f6e1c8a3..1d331090a44 100644
--- a/pkgs/development/ocaml-modules/zarith/default.nix
+++ b/pkgs/development/ocaml-modules/zarith/default.nix
@@ -6,9 +6,9 @@
 let source =
   if stdenv.lib.versionAtLeast ocaml.version "4.02"
   then {
-    version = "1.7";
-    url = https://github.com/ocaml/Zarith/archive/release-1.7.tar.gz;
-    sha256 = "0fmblap5nsbqq0dab63d6b7lsxpc3snkgz7jfldi2qa4s1kbnhfn";
+    version = "1.8";
+    url = https://github.com/ocaml/Zarith/archive/release-1.8.tar.gz;
+    sha256 = "1cn63c97aij19nrw5hc1zh1jpnbsdkzq99zyyk649c4s3xi3iqq7";
   } else {
     version = "1.3";
     url = http://forge.ocamlcore.org/frs/download.php/1471/zarith-1.3.tgz;

@thoughtpolice thoughtpolice mentioned this pull request Apr 23, 2019
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbgl @thoughtpolice @GrahamcOfBorg